Adapt the pixel_status to the change on the R1 format

[vmarandon]

According to A.1.5 section of the R1 CTA format, the pixel status contains:

• bit 0 and 1 : DVR Info
• bit 2 and 3 : channel info
• bit 4 : saturation
• bit 5, 6 and 7 : pixel trigger info.

The previous version of the code was assigning the hardware_failing_pixel at True in the pixel_status of the mon object only in the case : pixel_status == 0.
Nevertheless according to change request : CTA-CRE-ACA-303000-0038, R1 format out of the camera should always put the DVR info at 1, and so on the test does not work anymore.

The proposed changed will use only bit 2 and 3 for the comparison. According to the documentation, if the channel info is 0, then pixel if off/broken/missing.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (31f990f) to head (4da6129).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files           7        7           
  Lines         934      934           
=======================================
  Hits          798      798           
  Misses        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[frnbrun]

Thanks for the modifications to the code. Looks good to me!

[jlenain]

Thanks a lot for that ! Would you have a reference for this change request ? I am not really sure to understand what we are talking about.

[sizun]

The CRE reference is CTA-CRE-ACA-303000-0038.
It was discussed here: https://gitlab.cta-observatory.org/cta-computing/common/acada-array-elements/acada_lst1_int/-/issues/146#note_161626

[jlenain]

The CRE reference is CTA-CRE-ACA-303000-0038. It was discussed here: https://gitlab.cta-observatory.org/cta-computing/common/acada-array-elements/acada_lst1_int/-/issues/146#note_161626

Thanks a lot, @sizun !