Extend javascript emulation to handle rails CSRF protection #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rails CSRF protection wipes the session when it triggers
* to trigger it in cucumber we first enable it in test mode
by changing config/environments/test.rb
* we also need to make correct behaviour rely on the session being
present, so we set up a before_filter
* we need an action that configures the setup correctly:
session/establish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rails detects a non GET request that doesn't send the authentication_token parameter, it resets the session.
The current implementation of javascript emulation only changes the method to POST and also sends in the emulated _method parameter, but it does not emulate sending the CSRF token and so will break any behaviour that relies on the session being maintained (e.g. authentication).
This extends the javascript emulation to also parse the csrf_param and csrf_token from the meta tags and send them along with the _method parameter.