Adding support for custom JS DB strategies #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! We're the guys who made the patch request for the connection pooling thing. We really like the more flexible change you did instead, but unfortunately, we discovered while testing it that it doesn't work with our app, because we use a truncation strategy implemented by our own custom module, instead of DatabaseCleaner (which reminds us, you might want to require DBCleaner in the ... gemspec? we're not really sure, since it's a conditional dependency). We were wondering if you'd accept this patch to allow custom DB strategies. Thanks!