Allow users to disable database_cleaner hooks #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code LGTM. Travis failed for an unrelated reason - we can no longer assume mongodb is running on a travis slave. Let's just disable the mongo test when running on Travis. |
The hooks that automatically invoke database_cleaner before every scenario can sometimes cause problems when switching cleaning strategies between scenarios (issue cucumber#215). To allow a user to take full control of when database_cleaner is invoked, the configuration option Cucumber::Rails::Database.autorun_database_cleaner is provided, defaulting to true.
Kosmas
added a commit
that referenced
this pull request
Mar 4, 2013
Allow users to disable database_cleaner hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #215, this PR provides an option controlling the automatic invocation of
DatabaseCleaner.startbefore every scenario, andDatabaseCleaner.cleanafterwards (it defaults to true, naturally):I added the option as an accessor on
Cucumber::Rails::Databasefollowing the example of.javascript_strategy- it seemed the most natural place for it to live, but I'm happy to take alternative suggestions. :)Cheers,
Simon
(p.s. the failing scenario is broken in master, too - wasn't me guv, honest.)