-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations configuration in generator #292
Conversation
The Travis CI build is failing, but I cannot see how the failure has anything to do with my changes? |
@showaltb thank you. I'm going to have a look too. Do the tests pass on your local? |
@Kosmas, no, the tests do not pass on my local, even for master branch. The error is some kind of timeout, but it may be the same thing Travis CI is seeing. Unfortunately, I don't have any time now to dig deeper, sorry. The specs that I added to pass both on local and on Travis CI. |
@showaltb would you like to try again now that the tests are fixed? |
f6e3661
to
aa3852a
Compare
I rebased this against current master, and it builds, but don't merge it yet. It doesn't work against latest rails (4.2.5), because I need to do more investigation here. |
aa3852a
to
28b7848
Compare
Configures the "rake notes" task to find annotations in Cucumber's features directory and *.feature files.
28b7848
to
6abbeab
Compare
OK, this is good to merge now. I have re-written it to configure the annotations through the rake task, similar to how you are configuring the stats task. I also added a feature to test the new functionality. The new functionality is only enabled on Rails 4.2+. |
Add annotations configuration in generator
Thank you @showaltb ! |
For Rails 4.0+, the generator will add configuration entries to
config/environments/development.rb to include Cucumber's features
directory and .feature files in the "rake notes" run.