Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations configuration in generator #292

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

showaltb
Copy link
Contributor

For Rails 4.0+, the generator will add configuration entries to
config/environments/development.rb to include Cucumber's features
directory and .feature files in the "rake notes" run.

@showaltb
Copy link
Contributor Author

The Travis CI build is failing, but I cannot see how the failure has anything to do with my changes?

@Kosmas
Copy link
Member

Kosmas commented Jan 13, 2015

@showaltb thank you. I'm going to have a look too. Do the tests pass on your local?

@showaltb
Copy link
Contributor Author

@Kosmas, no, the tests do not pass on my local, even for master branch. The error is some kind of timeout, but it may be the same thing Travis CI is seeing. Unfortunately, I don't have any time now to dig deeper, sorry. The specs that I added to pass both on local and on Travis CI.

@Kosmas
Copy link
Member

Kosmas commented Dec 15, 2015

@showaltb would you like to try again now that the tests are fixed?

@showaltb showaltb force-pushed the add-annotations-config branch from f6e3661 to aa3852a Compare December 16, 2015 15:16
@showaltb
Copy link
Contributor Author

I rebased this against current master, and it builds, but don't merge it yet.

It doesn't work against latest rails (4.2.5), because rake notes doesn't load the environment, so the code in config/environments/development.rb doesn't run. Running rake environment notes works.

I need to do more investigation here.

@showaltb showaltb force-pushed the add-annotations-config branch from aa3852a to 28b7848 Compare December 16, 2015 18:10
Configures the "rake notes" task to find annotations in Cucumber's
features directory and *.feature files.
@showaltb showaltb force-pushed the add-annotations-config branch from 28b7848 to 6abbeab Compare December 16, 2015 18:35
@showaltb
Copy link
Contributor Author

OK, this is good to merge now. I have re-written it to configure the annotations through the rake task, similar to how you are configuring the stats task. I also added a feature to test the new functionality. The new functionality is only enabled on Rails 4.2+.

Kosmas added a commit that referenced this pull request Dec 17, 2015
Add annotations configuration in generator
@Kosmas Kosmas merged commit 506bab3 into cucumber:master Dec 17, 2015
@Kosmas
Copy link
Member

Kosmas commented Dec 17, 2015

Thank you @showaltb !

Kosmas added a commit that referenced this pull request Dec 17, 2015
@showaltb showaltb deleted the add-annotations-config branch December 17, 2015 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants