Remove support for Ruby versions <= 2.1 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtrasimplicity
force-pushed
the
feature/RemoveRuby2_1_Support
branch
from
bfe81e8 to
bdd7ef1
Compare
xtrasimplicity
force-pushed
the
feature/RemoveRuby2_1_Support
branch
from
48b5063 to
dc0feef
Compare
|
I like this change. |
CHANGELOG.md
Outdated
| @@ -5,7 +5,8 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO | |||
| ### Changed | |||
| * Renamed History.md to CHANGELOG.md, added contributing note, and this line in accordance with [cucumber/cucumber #251](https://github.com/cucumber/cucumber/issues/251) ([#345](https://github.com/cucumber/cucumber-rails/pull/345) [jaysonesmith](https://github.com/jaysonesmith)) | |||
| * Update .travis.yml with ruby versions ([#341](https://github.com/cucumber/cucumber-rails/pull/341) Jun Aruga) | |||
|
|
|||
| * Removed support for Ruby <= 2.1, to keep in line with the [core Cucumber-ruby repository](https://github.com/cucumber/cucumber-ruby/blob/master/CHANGELOG.md#302-2017-11-11). | |||
There was a problem hiding this comment.
Tiny detail: cucumber-ruby is the name of the repository. We can refer to that casing of the name in the text.
There was a problem hiding this comment.
Thanks @olleolleolle, I'll make that change now and merge the request. :)
| @@ -36,6 +36,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency('rdoc', '>= 3.4') | |||
| s.add_development_dependency('yard', '>= 0.8.7') | |||
|
|
|||
| s.required_ruby_version = '>= 2.2.0' | |||
There was a problem hiding this comment.
This is super. So helpful.
olleolleolle
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Cucumber-ruby 3.0.2 removes support for Ruby versions <= 2.1 and these particular versions are making the test suite very brittle, I propose we remove support starting from the next release (1.6).
Does anyone have any thoughts on this?
Thanks!