Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and generate 1.9 hash syntax #371

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Use and generate 1.9 hash syntax #371

merged 1 commit into from
Apr 12, 2018

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Apr 7, 2018

Summary

Use modern hash syntax since cucumber-rails only supports Rubies that can handle it.

Details

This updates both cucumber-rails' code and templates to use and generate modern hash syntax.

Motivation and Context

This removes the need to fix the code in each project after it has been generated.

How Has This Been Tested?

Existing tests and scenarios should still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@xtrasimplicity xtrasimplicity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! LGTM. :)

@mvz mvz merged commit c674bd9 into cucumber:master Apr 12, 2018
@mvz mvz deleted the hash-syntax branch April 12, 2018 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants