-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Rails 6.0.0.beta1 #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't really fault anything you've done. Minor stylistic things I would have done diff, but on the whole I don't see any reason to exclude this. All the guards are in place that I was concerned about.
EDIT: For other reviewers I didn't ask for a change to docs as realistically I don't think we should be promoting this yet, at least whilst the likelihood for failures and errors is high |
Good CI work all around! |
CI failed, but in my repository it passes. UPD: Looks like builds fail occasionally. |
LGTM! |
Hi @kotovalexarian, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Merged. Thanks for your contribution! |
Motivation and Context
I want to try Rails 6.0.0.beta1, but the gem
cucumber-rails
doesn't support it, so I added the support.How Has This Been Tested?
Rails 6.0.0.beta1 was added to Appraisal, so the whole test suite will run with it in CI.
Types of changes
Checklist: