Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 6.0.0.beta1 #405

Merged
merged 10 commits into from Feb 5, 2019
Merged

Add support for Rails 6.0.0.beta1 #405

merged 10 commits into from Feb 5, 2019

Conversation

kotovalexarian
Copy link
Member

Motivation and Context

I want to try Rails 6.0.0.beta1, but the gem cucumber-rails doesn't support it, so I added the support.

How Has This Been Tested?

Rails 6.0.0.beta1 was added to Appraisal, so the whole test suite will run with it in CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't really fault anything you've done. Minor stylistic things I would have done diff, but on the whole I don't see any reason to exclude this. All the guards are in place that I was concerned about.

@luke-hill
Copy link
Contributor

EDIT: For other reviewers I didn't ask for a change to docs as realistically I don't think we should be promoting this yet, at least whilst the likelihood for failures and errors is high

@olleolleolle
Copy link
Contributor

Good CI work all around!

@kotovalexarian
Copy link
Member Author

kotovalexarian commented Jan 29, 2019

CI failed, but in my repository it passes.

UPD: Looks like builds fail occasionally.

@olleolleolle
Copy link
Contributor

LGTM!

@luke-hill luke-hill merged commit cc447bf into cucumber:master Feb 5, 2019
@aslakhellesoy
Copy link
Contributor

Hi @kotovalexarian,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@luke-hill
Copy link
Contributor

Merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants