Tidy up Feature / Step / Support Code in Rails Feature Tests

[luke-hill]

Summary

Generic first pass at tidying / drying up feature/support/fixture code

Details

• Remove duplicate / un-needed steps
• Simplify features
• Generic linting

Motivation and Context

Tidy things up

How Has This Been Tested?

bundle exec rake - All green

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[mvz]

There is a conflict, otherwise 👍

[luke-hill]

I think this should be merged last, as by then everything else should be fixed.

[luke-hill]

This will need a re-review. Something b0rked up during the merge conflict. I think I picked the wrong bits and pieces so I've re-constructed the bits I "think" I'm missing. (Which caused the CI run on 9d50756 to fail for Rails6 branches).

[luke-hill]

Is this Good to merge chaps?

[mvz]

LGTM!