Fix up a few more rubocop offenses #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-hill
force-pushed
the
feature/tidy_up_cops
branch
from
621a586 to
a2f44c0
Compare
olleolleolle
approved these changes
Apr 26, 2019
| @@ -25,4 +25,5 @@ Style/RegexpLiteral: | |||
|
|
|||
| BlockLength: | |||
| Exclude: | |||
| - './spec/**/*_spec.rb' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed up some more rubocop offenses
Details
Fixed up LineLength cops (mainly), and a couple of other groups
I've also fixed some bugs in the rubocop config (As we were testing some of the
tmpfiles, now we don't test anything that's generated intotmp/I've also added a new rule ignore for all spec block sizes (As most of them are likely to break the 25line limit)How Has This Been Tested?
bundle exec rubocopTypes of changes
Checklist: