Dependency Update / Ruby Syntax overhaul #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few minor typo fixes
…build based on changes made in 5df9101#diff-9eec7a23bd3ec4020b3ff843a87c0e4a As the build was never broken, one can only assume the changes made at the time were based on an understanding Rails 5.1 did 'something' which in fact it didn't. I've removed this logic but left the two sanitizer methods with a comment. These can be removed in cucumber-rails 2.1 if no further issues are detected. However it could be that this might raise an issue. However as this is only internal testing code, any issues should be negligible. Obviously as this suite is reasonably old and used in a variety of places, there could be issues. In which case reverting this commit would suffice. However, this should not be necessary as the code should never work (Modifying frozen strings) On-top of this, a minor refactor has been made to use better syntax for the auto-generated files (Later Ruby syntax)
…rsion, let bundler handle it
luke-hill
force-pushed
the
refactor/ruby_syntax_update
branch
from
f84ee56 to
5fd50b6
Compare
danascheider
approved these changes
Sep 4, 2019
| gem_regexp = /gem ["']#{name}["'].*$/ | ||
| gemfile_content = File.read(expand_path('Gemfile')) | ||
| puts "Frozen status of gem_regexp #{gem_regexp.frozen?}" | ||
| puts "Frozen status of gemfile_content #{gemfile_content.frozen?}" |
There was a problem hiding this comment.
Suggested change
| puts "Frozen status of gemfile_content #{gemfile_content.frozen?}" | |
| puts "Frozen status of gemfile_content: #{gemfile_content.frozen?}" |
| gem_regexp = /gem ["']#{name}["'].*$/ | ||
| gemfile_content = File.read(expand_path('Gemfile')) | ||
| puts "Frozen status of gem_regexp #{gem_regexp.frozen?}" |
There was a problem hiding this comment.
Maybe this is a nitpick, but I think this message would be clearer if there were a colon:
Suggested change
| puts "Frozen status of gem_regexp #{gem_regexp.frozen?}" | |
| puts "Frozen status of gem_regexp #{gem_regexp.frozen?}" |
There was a problem hiding this comment.
I'm not planning on committing this. It's more for my benefit.
This code "should not" work
| @@ -46,7 +47,7 @@ Feature: Allow Cucumber to rescue exceptions | |||
| Scenario: Don't allow rescue | |||
| When I write to "features/posts.feature" with: | |||
| """ | |||
| Feature: posts | |||
| Feature: Posts | |||
There was a problem hiding this comment.
I am very appreciative of this sort of change.
…editors or code-reviewers This was because we were mutating frozen strings but in a different thread which didn't adhere to Rubys magic comment.
|
Ping for review. In essence
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a couple of small syntax issues, it adds a new core-dependency (Which simplifies a lot of logic and doesn't really change XP)
Details
Motivation and Context
Remove un-needed lines of code. Simplify contributor block
How Has This Been Tested?
CI
Screenshots (if appropriate):
Types of changes
Checklist: