Refactor/abc condition #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
reviewed
Dec 6, 2019
| delete_environment_variable 'BUNDLE_BIN_PATH' | ||
| delete_environment_variable 'BUNDLE_GEMFILE' | ||
| command_result = run_rails_new_command(options) | ||
| validate_rails_new_success(command_result) |
There was a problem hiding this comment.
I think this method will be clearer if run_rails_new_command and validate_rails_new_success are merged. I think it also makes sense to have validation be part of the running.
| env['action_dispatch.show_detailed_exceptions'] = !ActionController::Base.allow_rescue | ||
| env['action_dispatch.show_exceptions'] = !env['action_dispatch.show_detailed_exceptions'] |
| emulated_method&.casecmp(method)&.zero? | ||
| end | ||
|
|
||
| def add_hidden_input(document, js_form) |
There was a problem hiding this comment.
How about naming this add_hidden_method_input?
|
|
||
| js_form | ||
| end | ||
|
|
||
| def same?(emulated_method, method) | ||
| emulated_method&.casecmp(method)&.zero? |
There was a problem hiding this comment.
This line tells me that emulated_method is never nil, so the safe calls can be removed.
| end | ||
|
|
||
| def csrf_and_non_get?(emulated_method) | ||
| csrf? && !emulated_method.casecmp('get').zero? |
There was a problem hiding this comment.
Here, you can use !same?(emulated_method, 'get').
mvz
reviewed
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix up some rubocop todo's
Details
Refactor some complex methods. Use better names where appropriate
Motivation and Context
Fixes up todo file in rubocop_todo.yml
How Has This Been Tested?
CI
Types of changes
Checklist: