-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to prepend instead of alias chaining methods #457
Conversation
Looks like the test failures are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix either the directory or namespace (As they don't co-incide)
Don't worry about any rails 6 errors for now. I'm doing some investigating for that currently.
@luke-hill I can definitely change it. What sort of naming would you prefer? |
your namespacing has an Extensions module. So either add a new folder for that or remove that module. |
@luke-hill what about the other stuff in |
Things aren't great here. So if you want to fix up more stuff, go nuts. I'm just here to make sure we make stuff better ideally with each PR. |
ping @wagenet |
@luke-hill sorry for the delay. I think it is ready now. Let me know if you need anything else. |
@luke-hill I don't think the CI failures are my fault, but please let me know if I'm mistaken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore any rails6 failures. But other failures may need investigating.
Also it is highly likely this area is untested, or has not enough tests. As this bit deals with the more rails part of the project.
@luke-hill I'm seeing lots of stuff around deprecations in the failures. |
The failures aren't anything to worry about if they're rails6. They changed something between 6.0.1 and 6.0.2 that we've yet to hear back / diagnose |
@luke-hill ok, looks like we're probably ok now. |
Hi @wagenet, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Fixes #454