Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to prepend instead of alias chaining methods #457

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Jan 10, 2020

Fixes #454

@wagenet
Copy link
Contributor Author

wagenet commented Jan 10, 2020

Looks like the test failures are unrelated.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix either the directory or namespace (As they don't co-incide)

Don't worry about any rails 6 errors for now. I'm doing some investigating for that currently.

@wagenet
Copy link
Contributor Author

wagenet commented Jan 13, 2020

@luke-hill I can definitely change it. What sort of naming would you prefer?

@luke-hill
Copy link
Contributor

your namespacing has an Extensions module. So either add a new folder for that or remove that module.

@wagenet
Copy link
Contributor Author

wagenet commented Jan 15, 2020

@luke-hill what about the other stuff in lib/cucumber/rails/action_controller.rb? Previously, it had things from two different modules.

@luke-hill
Copy link
Contributor

Things aren't great here. So if you want to fix up more stuff, go nuts. I'm just here to make sure we make stuff better ideally with each PR.

@luke-hill
Copy link
Contributor

ping @wagenet

@wagenet
Copy link
Contributor Author

wagenet commented Feb 13, 2020

@luke-hill sorry for the delay. I think it is ready now. Let me know if you need anything else.

@wagenet
Copy link
Contributor Author

wagenet commented Feb 14, 2020

@luke-hill I don't think the CI failures are my fault, but please let me know if I'm mistaken.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore any rails6 failures. But other failures may need investigating.

Also it is highly likely this area is untested, or has not enough tests. As this bit deals with the more rails part of the project.

@wagenet
Copy link
Contributor Author

wagenet commented Feb 18, 2020

@luke-hill I'm seeing lots of stuff around deprecations in the failures.

@luke-hill
Copy link
Contributor

The failures aren't anything to worry about if they're rails6. They changed something between 6.0.1 and 6.0.2 that we've yet to hear back / diagnose

@wagenet
Copy link
Contributor Author

wagenet commented Feb 18, 2020

@luke-hill ok, looks like we're probably ok now.

@luke-hill luke-hill merged commit f2b7709 into cucumber:master Feb 19, 2020
@aslakhellesoy
Copy link
Contributor

Hi @wagenet,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use prepend instead of alias method chaining
3 participants