Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve NameError occurring in TravisCI #460

Merged

Conversation

damonjmurray
Copy link

The build is failing with multiple occurrences of the following error:
uninitialized constant Cucumber::Rails::ActionDispatch::IntegrationTest (NameError)

Example:
https://travis-ci.org/cucumber/cucumber-rails/jobs/650040930

I have also encountered this error when pointing a project at a local build
of cucumber-rails at master.

As IntegrationTest does not live in the
Cucumber::Rails::ActionDispatch namespace, this commit makes the
change to read ActionDispatch::IntegrationTest from the global
namespace.

The build is failing with multiple occurrences of the following error:
`uninitialized constant Cucumber::Rails::ActionDispatch::IntegrationTest
(NameError)`

Example:
https://travis-ci.org/cucumber/cucumber-rails/jobs/650040930

I have also encountered this error when pointing a project at a local build
of `cucumber-rails` at `master`.

As `IntegrationTest` does not live in the
`Cucumber::Rails::ActionDispatch` namespace, this commit makes the
change to read `ActionDispatch::IntegrationTest` from the global
namespace.
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a helpful fix!

@olleolleolle
Copy link
Contributor

The build failures on rails 6 builds are about not finding the rake task webpacker:install.

That's unrelated, I believe.

@olleolleolle olleolleolle merged commit a2e3abd into cucumber:master Feb 14, 2020
@aslakhellesoy
Copy link
Contributor

Hi @damonjmurray,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@damonjmurray damonjmurray deleted the bugfix/fix_integrationtest_namespace branch February 14, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants