Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #464

Merged
merged 3 commits into from
Jun 1, 2020
Merged

Fix CI #464

merged 3 commits into from
Jun 1, 2020

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented May 30, 2020

Summary

Just trying to get the CI green. This PR closes #461.

Details

CI is broken on Rails 6. This PR introduces a number of changes to get CI green again:

  • Delay webpacker installation to a point where cucumber-rails is properly setup in the dummy application Gemfile. Otherwise we get warnings like this:

WARNING: Cucumber-rails required outside of env.rb. The rest of loading is being deferred
until env.rb is called. To avoid this warning, move 'gem 'cucumber-rails', require: false'under only group :test in your Gemfile. If already in the :test group, be sure you arespecifying 'require: false'.

and also a hard error about rails generator not finding the webpacker:install task. Honestly I'm not fully sure why it's happening, but we're running webpacker:install later on, so it's unnecessary to include webpacker on the initial dummy application generation.

  • Increase aruba's commands timeout, since sassc compilation is very slow, and it comes by default on Rails 6.

  • Bump the nodejs version being used to a version compatible with webpacker. Otherwise we get errors like this:

Webpacker requires Node.js >= 8.16.0 and you are using 8.12.0
Please upgrade Node.js https://nodejs.org/en/download/

Motivation and Context

To have a green CI.

How Has This Been Tested?

In CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Delay it until the cucumber-rails dependency is properly setup.
@deivid-rodriguez deivid-rodriguez force-pushed the fix_ci branch 4 times, most recently from 95a7e81 to f563aec Compare May 31, 2020 12:33
`sassc` compilation is very slow, and comes by default with Rails 6.
@deivid-rodriguez
Copy link
Member Author

This is ready for a review!

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grand, and is now GREEN!

Looks good to me and it's ready to go.

Also: The description is very clear, and explains what was changed and why.

Since it provides by default a recent enough nodejs version that plays
nice with webpacker.
@deivid-rodriguez
Copy link
Member Author

Thanks for your reviews!

I made one last minute change to fix the "Nodejs version is too old" issue. Instead of all the workarounds to upgrade the nodejs version manually, I updated TravisCI configuration to use bionic which seems to provide a high enough version of nodejs by default.

@deivid-rodriguez
Copy link
Member Author

I will merge this after the CI 👍.

@deivid-rodriguez
Copy link
Member Author

Going in!

@deivid-rodriguez deivid-rodriguez merged commit ccd9612 into master Jun 1, 2020
@deivid-rodriguez deivid-rodriguez deleted the fix_ci branch June 1, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failures (Rails 6.0.1)
3 participants