-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #464
Fix CI #464
Conversation
Delay it until the cucumber-rails dependency is properly setup.
95a7e81
to
f563aec
Compare
`sassc` compilation is very slow, and comes by default with Rails 6.
This is ready for a review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks grand, and is now GREEN!
Looks good to me and it's ready to go.
Also: The description is very clear, and explains what was changed and why.
Since it provides by default a recent enough nodejs version that plays nice with webpacker.
Thanks for your reviews! I made one last minute change to fix the "Nodejs version is too old" issue. Instead of all the workarounds to upgrade the nodejs version manually, I updated |
I will merge this after the CI 👍. |
Going in! |
Summary
Just trying to get the CI green. This PR closes #461.
Details
CI is broken on Rails 6. This PR introduces a number of changes to get CI green again:
cucumber-rails
is properly setup in the dummy applicationGemfile
. Otherwise we get warnings like this:and also a hard error about
rails
generator not finding thewebpacker:install
task. Honestly I'm not fully sure why it's happening, but we're runningwebpacker:install
later on, so it's unnecessary to includewebpacker
on the initial dummy application generation.Increase aruba's commands timeout, since
sassc
compilation is very slow, and it comes by default on Rails 6.Bump the nodejs version being used to a version compatible with webpacker. Otherwise we get errors like this:
Motivation and Context
To have a green CI.
How Has This Been Tested?
In CI.
Types of changes
Checklist: