Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop including all Rails gems #486

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Stop including all Rails gems #486

merged 4 commits into from
Oct 29, 2020

Conversation

langalex
Copy link
Contributor

Summary

By only depending on railties, optional rails gems are not pulled
in automatically, leaving apps with fewer dependencies.

Motivation and Context

By depending on rails, cucumber-rails forces apps depending on it to pull
in all Rails gems, including optional ones such as actioncable
or activejob. This leaves apps more bloated than they have to be.

How Has This Been Tested?

Tests are still passing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

By depending on rails, cucumber-rails forces apps depending on it to pull
in all Rails gems, including optional ones such as actioncable
or activejob.

By only depending on railties, optional rails gems are not pulled
in automatically, leaving apps with fewer dependencies.
@luke-hill
Copy link
Contributor

We made a change a bit ago (As we had both of railties / rails) to remove railties. Evidently we should have just removed rails.

Could you make this change in all other relevant locations and add a changelog entry

@langalex
Copy link
Contributor Author

@luke-hill thanks will do. Can you clarify what you mean by "all other relevant locations". I don't think it's necessary for example to change the dependency for all the Gemfiles.

@langalex
Copy link
Contributor Author

can this be merged?

@luke-hill
Copy link
Contributor

Could you update the relevant locations that also have rails. I think there's some internal testing gemfiles and a couple of other places.

@olleolleolle
Copy link
Contributor

https://github.com/cucumber/cucumber-rails/tree/master/gemfiles here is a bunch of Gemfiles with rails in them.

@langalex
Copy link
Contributor Author

changed the Gemfiles and tests are green.

@luke-hill luke-hill merged commit 10abdb6 into cucumber:master Oct 29, 2020
@aslakhellesoy
Copy link
Contributor

Hi @langalex,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@langalex langalex deleted the stop-including-all-rails-gems branch October 29, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants