-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop including all Rails gems #486
Stop including all Rails gems #486
Conversation
By depending on rails, cucumber-rails forces apps depending on it to pull in all Rails gems, including optional ones such as actioncable or activejob. By only depending on railties, optional rails gems are not pulled in automatically, leaving apps with fewer dependencies.
We made a change a bit ago (As we had both of railties / rails) to remove railties. Evidently we should have just removed rails. Could you make this change in all other relevant locations and add a changelog entry |
@luke-hill thanks will do. Can you clarify what you mean by "all other relevant locations". I don't think it's necessary for example to change the dependency for all the |
can this be merged? |
Could you update the relevant locations that also have rails. I think there's some internal testing gemfiles and a couple of other places. |
https://github.com/cucumber/cucumber-rails/tree/master/gemfiles here is a bunch of Gemfiles with |
changed the Gemfiles and tests are green. |
Hi @langalex, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Summary
By only depending on railties, optional rails gems are not pulled
in automatically, leaving apps with fewer dependencies.
Motivation and Context
By depending on rails, cucumber-rails forces apps depending on it to pull
in all Rails gems, including optional ones such as actioncable
or activejob. This leaves apps more bloated than they have to be.
How Has This Been Tested?
Tests are still passing.
Types of changes
Checklist: