-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET] Adopt c# 10 file scoped namespaces #271
Conversation
Parser.cs is not changed because it has this header
|
You can edit dotnet/gherkin-csharp.razor to apply the name spaces to the generated code. Instruction on how to generate the parser can be found in CONTRIBUTING.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the 1 spacing/formatting item found (commented elsewhere), this looks good.
It would be nice, for consistency's sake, to complete this PR by adding in the changes required of the razor file that @mpkorstanje suggested. I can walk you through them if you need it.
please squash this PR during merging |
I propose to make changes in code-generation later if needed, because I'm planning to propose another changes in this library, including code style changes |
🤔 What's changed?
Adopt c# 10 file scoped namespaces
documentation: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces
⚡️ What's your motivation?
Adopt modern c# language feature to simplify code base
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
no changes in product. code style changes only
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.