Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Node.js versions #365

Merged
merged 2 commits into from
Feb 7, 2025
+5 −4
Merged

Update supported Node.js versions #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac0b78e
Update supported Node.js versions
davidjgoss Feb 6, 2025
40da9bd
update CHANGELOG.md
davidjgoss Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '22'
cache: 'npm'
cache-dependency-path: javascript/package-lock.json
- run: npm install-test
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-javascript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ jobs:
matrix:
os:
- ubuntu-latest
node-version: ["16.x", "17.x", "18.x"]
node-version: ["18.x", "20.x", "22.x", "23.x"]
include:
- os: windows-latest
node-version: "18.x"
node-version: "22.x"
- os: macos-latest
node-version: "18.x"
node-version: "22.x"

steps:
- name: set git core.autocrlf to 'input'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
### Changed
- [.NET] Reduce NuGet size by only targeting .NET Standard 2.0
- [.NET] Changed some types from class to struct, removed IGherkinLine interface and changes some functions from Array to Enumerable
- [JavaScript] BREAKING CHANGE: Update supported Node.js versions to 18, 20, 22 and 23 ([#365](https://github.com/cucumber/gherkin/pull/365))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't break anything I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s more like drawing a line because anyone using this on say Node.js 16 might be okay today but it will break at some unknown future point when we use a new syntax or standard library function.


### Fixed
- [.NET] Fix NuGet package generation
Expand Down
Loading