Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give a more useful error message if remote init fails #5720

Merged
merged 3 commits into from
Oct 11, 2023
Merged

give a more useful error message if remote init fails #5720

merged 3 commits into from
Oct 11, 2023
+42 −2

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Sep 6, 2023 •
edited
Loading

Closes #5719

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are not included - this change should not break any existing tests.
  • CHANGES.md this is a logging change only, should not need changelog.
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim requested a review from hjoliver September 6, 2023 09:06
@wxtim wxtim mentioned this pull request Sep 6, 2023
Closed
4 tasks
@wxtim wxtim self-assigned this Sep 6, 2023
@wxtim wxtim added bug? Not sure if this is a bug or not small could be better Not exactly a bug, but not ideal. labels Sep 6, 2023
@wxtim wxtim added this to the cylc-8.2.2 milestone Sep 6, 2023
@wxtim wxtim force-pushed the fix.more_platform_info_in_errors branch from 3a833a2 to 0c3cc43 Compare September 6, 2023 09:25
@wxtim wxtim linked an issue Sep 11, 2023 that may be closed by this pull request
Platforms bug: bad hosts (mainly logging) #5719
Closed
4 tasks
hjoliver
hjoliver approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.2, cylc-8.2.3 Oct 4, 2023
@wxtim wxtim requested a review from oliver-sanders October 11, 2023 12:35
oliver-sanders
oliver-sanders previously approved these changes Oct 11, 2023
View reviewed changes
@oliver-sanders oliver-sanders self-requested a review October 11, 2023 12:51
@oliver-sanders oliver-sanders merged commit 0655c91 into cylc:8.2.x Oct 11, 2023
@wxtim wxtim deleted the fix.more_platform_info_in_errors branch October 12, 2023 07:59
wxtim added a commit to wxtim/cylc that referenced this pull request Oct 18, 2023
@wxtim
Merge remote-tracking branch 'upstream/master' into test.sim_mode
12ba4c9 
* upstream/master:
  speed up import time (cylc#5770)
  graphql: remove extraLogs field (cylc#5672)
  give a more useful error message if remote init fails (cylc#5720)
  clarify SLURM job handler docs (cylc#5748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
bug? Not sure if this is a bug or not could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
cylc-8.2.3
Development

Successfully merging this pull request may close these issues.

Platforms bug: bad hosts (mainly logging)
3 participants
@wxtim @hjoliver @oliver-sanders