-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use resolve-package-path
to resolve installed dependency versions more reliably
#26033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 flaky tests on run #44605 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lmiller1990
reviewed
Mar 7, 2023
lmiller1990
reviewed
Mar 7, 2023
mike-plummer
reviewed
Mar 7, 2023
…-io/cypress into launchpad-dep-resolution-exports
@astone123 Still seeing a lot of test failures here, happy to ✅ once those are resolved |
…-io/cypress into launchpad-dep-resolution-exports
@mike-plummer okay we should be good now |
mike-plummer
approved these changes
Mar 8, 2023
lmiller1990
approved these changes
Mar 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
There are some dependencies that we can't resolve with
require.resolve
, because of one of the following reasons:exports
defined, butpackage.json
is not one of the exportsreact-scripts
, there is no entrypoint, just a bin).We need to find a way around these limitations so that we can figure out if a dependency is installed, and if it is, which version is installed. Lachlan and I found a package called
resolve-package-path
that does the trick, working around theexports
and entrypoint limitations and allowing us to detect dependencies that are installed.TLDR: It looks like we can't use
require.resolve
to figure out which dependencies of which packages are installed.Further reading
Steps to test
yarn create vite my-app --template react
my-app
node_modules/react
, removepackage.json
from the exports key inpackage.json
my-app
and click Component TestingHow has the user experience changed?
There should be no noticeable change for the user
PR Tasks
cypress-documentation
?type definitions
?