Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints in generate-stream #209

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Fix type hints in generate-stream #209

merged 2 commits into from
Mar 13, 2025

Conversation

souenzzo
Copy link
Contributor

@souenzzo souenzzo commented Feb 11, 2025 •
edited
Loading

writer is only used in one place:

  • JsonFactory#createGenerator, used as a Writer

There is no reason to tag as a BufferWriter.

Note: JsonFactory#createGenerator(Writer) is deprecated. we may have to deal with this in the future.

dakrone
dakrone approved these changes Mar 13, 2025
View reviewed changes
Copy link
Owner

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dakrone dakrone merged commit 66d1a31 into dakrone:master Mar 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souenzzo @dakrone