-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the xmin horizon to running query display #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just a couple of minor comments.
Also, I'm wondering if you put the new column close to left side intentionally? Is there a business logic reason for this?
b20b7a1
to
375c872
Compare
The tests crash on this although the read / write parts where not changed in this patch (
Notes:
I also don't get this crash in my local env... |
No idea why; I can take a closer look today In the meantime, I have pushed your three other fixes (manpage, mypy, isort) to master (you might want to rebase the remaining commit here). The test failure reproduces there so it's indeed unrelated to this PR. |
It's due to humanize 4.12.0, I can reproduce locally after |
Fixed in #432. |
No, it was easier while I was testing and it seemed as good a place as any. |
The xmin horizon was added in 9.4 in commit [1]. [1] postgres/postgres@dd1a3bc
The xmin horizon was added in 9.4 in commit [1], the addition of the column was asked in #425.
[1] postgres/postgres@dd1a3bc