Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the xmin horizon to running query display #431

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

blogh
Copy link
Collaborator

@blogh blogh commented Feb 13, 2025

The xmin horizon was added in 9.4 in commit [1], the addition of the column was asked in #425.

[1] postgres/postgres@dd1a3bc

@blogh blogh marked this pull request as draft February 13, 2025 10:56
@blogh blogh marked this pull request as ready for review February 13, 2025 15:29
@blogh blogh requested a review from dlax February 13, 2025 15:29
Copy link
Member

@dlax dlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a couple of minor comments.

Also, I'm wondering if you put the new column close to left side intentionally? Is there a business logic reason for this?

@blogh blogh force-pushed the xmin_425 branch 2 times, most recently from b20b7a1 to 375c872 Compare February 17, 2025 10:34
@blogh
Copy link
Collaborator Author

blogh commented Feb 17, 2025

The tests crash on this although the read / write parts where not changed in this patch (tests/test_views.txt).

    -6239   1        pgbench                   pgbench         postgres            local 0.1    1.0  7B       12B       0.000000                N N        idle in trans UPDATE pgbench_accounts SET abalance = abalance + 141 WHERE aid = 1932841;
    +6239   1        pgbench                   pgbench         postgres            local 0.1    1.0  7B       12.3B     0.000000                N N        idle in trans UPDATE pgbench_accounts SET abalance = abalance + 141 WHERE aid = 1932841;
    -6228   2        pgbench                   pgbench         postgres            local 0.2    1.0  0B       1.08M     0.000413                  Y               active \_ UPDATE pgbench_accounts SET abalance = abalance + 141 WHERE aid = 1932841;
    +6228   2        pgbench                   pgbench         postgres            local 0.2    1.0  0.2B     1.08M     0.000413                  Y               active \_ UPDATE pgbench_accounts SET abalance = abalance + 141 WHERE aid = 1932841;

Notes:

  • What to look for 12B -> 12.3B and 0 -> 0.2B
  • The unit seems to be B/s instead of B and it's a delta from last mesurement

I also don't get this crash in my local env...
Do you have an idea of why the display of these floats would change ?

@dlax
Copy link
Member

dlax commented Feb 18, 2025

The tests crash on this although the read / write parts where not changed in this patch (tests/test_views.txt).

No idea why; I can take a closer look today or at least before the end of the week.

In the meantime, I have pushed your three other fixes (manpage, mypy, isort) to master (you might want to rebase the remaining commit here). The test failure reproduces there so it's indeed unrelated to this PR.

@dlax
Copy link
Member

dlax commented Feb 18, 2025

It's due to humanize 4.12.0, I can reproduce locally after pip install -U humanize.

@dlax
Copy link
Member

dlax commented Feb 18, 2025

Fixed in #432.

@blogh
Copy link
Collaborator Author

blogh commented Feb 18, 2025

Also, I'm wondering if you put the new column close to left side intentionally? Is there a business logic reason for this?

No, it was easier while I was testing and it seemed as good a place as any.

The xmin horizon was added in 9.4 in commit [1].
[1] postgres/postgres@dd1a3bc
@blogh blogh merged commit 681a9c5 into dalibo:master Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants