Add lower-level logging of unexpected exceptions #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 76.85% // Head: 76.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## draft #294 +/- ##
==========================================
- Coverage 76.85% 76.71% -0.15%
==========================================
Files 14 14
Lines 2320 2323 +3
Branches 373 373
==========================================
- Hits 1783 1782 -1
- Misses 391 393 +2
- Partials 146 148 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
That is great! Thank you @jwodder -- I will merge, and rerun asap (want to make sure zarrs are clean etc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #293.
I was able to produce an MVCE of the problem (which I reported as a bug in anyio: agronholm/anyio#490). Apparently, some exception is getting raised inside
stream_null_command()— either immediately inside it or within something that's using it as a context manager — but I have no idea what that exception might be. I've added more logging for now.