Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support overriding application owner with config option #73

Merged
merged 2 commits into from
Jan 4, 2020
Merged

support overriding application owner with config option #73

merged 2 commits into from
Jan 4, 2020

Conversation

ericdude4
Copy link
Contributor

Currently, the application_owner config option is ignored. Referenced in docs: https://hexdocs.pm/ex_oauth2_provider/ExOauth2Provider.html#module-configuration

Issue #67

@danschultzer
Copy link
Owner

Thanks! I was thinking about this and prefer instead to require an explicit override like this:

defmodule MyApp.OauthApplications.OauthApplication do
  use Ecto.Schema
  use ExOauth2Provider.Applications.Application

  schema "oauth_applications" do
    belongs_to :owner, MyApp.Users.User

    application_fields()

    timestamps()
  end
end

This would also prevent compile time issues with config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants