DAOS-12751 dfuse: Improve evict command. #12633

ashleypittman · 2023-07-14T13:12:31Z

Improve error cases where path is not backed by dfuse.
Lock forget commands against inode query.
Print and accept inodes as integers only.

Evict the build tree as part of the DaosBuild test.

Required-githooks: true

Signed-off-by: Ashley Pittman [email protected]

Improve error cases where path is not backed by dfuse. Lock forget commands against inode query. Print and accept inodes as integers only. Evict the build tree as part of the DaosBuild test. Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>

github-actions · 2023-07-14T13:12:50Z

Bug-tracker data:
Ticket title is 'dfuse needs a mechanism to evict cached pool and container handles'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-12751

daosbuild1

LGTM. No errors found by checkpatch.

Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>

daosbuild1

LGTM. No errors found by checkpatch.

Test-tag: dfuse Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>

daosbuild1 · 2023-07-17T11:34:30Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12633/3/execution/node/145/log

daosbuild1

LGTM. No errors found by checkpatch.

ashleypittman · 2023-07-17T11:37:03Z

src/utils/daos_hdlr.c

+		if (rc == ENOTTY) {
+			rc = -DER_MISC;


This doesn't' change the value of rc but it does remove the extra output. I've filed https://daosio.atlassian.net/browse/DAOS-13977 to remove -DER_MISC across this command.

daltonbohning · 2023-07-17T14:44:19Z

src/client/dfuse/ops/forget.c

-	DFUSE_TRA_DEBUG(fs_handle, "Forgetting %zi", count);
+	DFUSE_TRA_DEBUG(dfuse_info, "Forgetting %zi", count);
+
+	D_RWLOCK_RDLOCK(&dfuse_info->di_forget_lock);


D_RWLOCK_RDLOCK, not D_RWLOCK_WRLOCK?
Is this because d_hash_rec_ndecref has its own lock?

I want forgets to happen in parallel as they do now so forget takes a reader lock (although it does modify - this is protected by the hash table) but I also want the ioctl to block whilst there are pending forget operations so that takes a writer lock. It's the only way I could think of for the ioctl to pause which pending operations are happening. The kernel seems to send a small number of forgetmany operation, each with a large number of forgets so this won't guarantee that the kernel has completed but it does at least pause the reader for any in-flight to complete.

daltonbohning · 2023-07-17T14:45:38Z

src/tests/ftest/dfuse/daos_build.py

+                'daos filesystem query {}'.format(mount_dir),
+                'daos filesystem evict {}'.format(build_dir),
+                'daos filesystem query {}'.format(mount_dir),


Is this a fix or a workaround?

Neither, this is to see how long the forget takes and see how effective it is. Plus check that it doesn't deadlock of course.

First results are in, all 3 commands took less than 0.00 seconds so the evict is fast, the first two commands reported 45065 inode in memory, the last one 4951. I don't think this test should be putting anything other than the build_dir so it would be interesting to see if nodes does drop to 1, if we could run the command in json mode remotely and get the evicted inode number then we could wait for it but I think that's outside the scope of this PR.

All tests had exactly the same values which shouldn't be a surprise, the files that aren't being evicted are the venv files which makes sense.

mchaarawi · 2023-07-21T16:33:45Z

the results are missing for the hw medium stage. it seems to have been skipped in the CI run?

ashleypittman · 2023-07-21T16:35:03Z

the results are missing for the hw medium stage. it seems to have been skipped in the CI run?

It ran with Test-tag: dfuse

mchaarawi · 2023-07-21T16:37:50Z

the results are missing for the hw medium stage. it seems to have been skipped in the CI run?

It ran with Test-tag: dfuse

shouldn't this be:
Feature: dfuse
since this is not a test only change?

ashleypittman · 2023-07-21T16:39:48Z

the results are missing for the hw medium stage. it seems to have been skipped in the CI run?

It ran with Test-tag: dfuse

shouldn't this be: Feature: dfuse since this is not a test only change?

Features rather than Feature but yes, I think that would have done more testing and be enough to have at least one test in every stage. I'll update my processes.

mchaarawi · 2023-07-21T16:41:43Z

the results are missing for the hw medium stage. it seems to have been skipped in the CI run?

It ran with Test-tag: dfuse

shouldn't this be: Feature: dfuse since this is not a test only change?

Features rather than Feature but yes, I think that would have done more testing and be enough to have at least one test in every stage. I'll update my processes.

thanks. please re-add gatekeeper when the testing completes

Features: dfuse

daosbuild1

LGTM. No errors found by checkpatch.

Multiple cherry-picks to add daos fs query feature for fuse statistics. Helpful for understanding and tuning DAOS performance when dfuse is used. DAOS-13625 dfuse: Merge the info and projection_info structs. (#11881) DAOS-13658 dfuse: Add filesystem query command. (#12367) DAOS-12751 control: Add a daos filesystem evict command. (#12331) DAOS-12751 dfuse: Improve evict command. (#12633) DAOS-13625 dfuse: Remove dfuse_projection_info entirely. (#12796) DAOS-13625 dfuse: Replace fs_handle with dfuse_info. (#12894) DAOS-13625 dfuse: Add core inode_lookup() and inode_decref() functions. (#12573) DAOS-14411 dfuse: Add per-container statistics. (#12819) Signed-off-by: Ashley Pittman <[email protected]>

Multiple cherry-picks to add daos fs query feature for fuse statistics. Helpful for understanding and tuning DAOS performance when dfuse is used. DAOS-13625 dfuse: Merge the info and projection_info structs. (#11881) DAOS-13658 dfuse: Add filesystem query command. (#12367) DAOS-12751 control: Add a daos filesystem evict command. (#12331) DAOS-12751 dfuse: Improve evict command. (#12633) DAOS-13625 dfuse: Remove dfuse_projection_info entirely. (#12796) DAOS-13625 dfuse: Replace fs_handle with dfuse_info. (#12894) DAOS-13625 dfuse: Add core inode_lookup() and inode_decref() functions. (#12573) DAOS-14411 dfuse: Add per-container statistics. (#12819) Features: dfuse Required-githooks: true Change-Id: I8ae3cc743697c2434ae0d54b382ee6c585a3b033 Signed-off-by: Ashley Pittman <[email protected]> Signed-off-by: Jeff Olivier <[email protected]>

Multiple cherry-picks to add daos fs query feature for fuse statistics. Helpful for understanding and tuning DAOS performance when dfuse is used. DAOS-13625 dfuse: Merge the info and projection_info structs. (#11881) DAOS-13658 dfuse: Add filesystem query command. (#12367) DAOS-12751 control: Add a daos filesystem evict command. (#12331) DAOS-12751 dfuse: Improve evict command. (#12633) DAOS-13625 dfuse: Remove dfuse_projection_info entirely. (#12796) DAOS-13625 dfuse: Replace fs_handle with dfuse_info. (#12894) DAOS-13625 dfuse: Add core inode_lookup() and inode_decref() functions. (#12573) DAOS-14411 dfuse: Add per-container statistics. (#12819) DAOS-14411 control: Expose dfuse statistics as yaml. (#13876) Features: dfuse Required-githooks: true Change-Id: I8ae3cc743697c2434ae0d54b382ee6c585a3b033 Signed-off-by: Ashley Pittman <[email protected]> Signed-off-by: Jeff Olivier <[email protected]>

Multiple cherry-picks to add daos fs query feature for fuse statistics. Helpful for understanding and tuning DAOS performance when dfuse is used. DAOS-13625 dfuse: Merge the info and projection_info structs. (#11881) DAOS-13658 dfuse: Add filesystem query command. (#12367) DAOS-12751 control: Add a daos filesystem evict command. (#12331) DAOS-12751 dfuse: Improve evict command. (#12633) DAOS-13625 dfuse: Remove dfuse_projection_info entirely. (#12796) DAOS-13625 dfuse: Replace fs_handle with dfuse_info. (#12894) DAOS-13625 dfuse: Add core inode_lookup() and inode_decref() functions. (#12573) DAOS-14411 dfuse: Add per-container statistics. (#12819) DAOS-14411 control: Expose dfuse statistics as yaml. (#13876) Changed base branch to google/2.4 for daos_build test Change-Id: I8ae3cc743697c2434ae0d54b382ee6c585a3b033 Signed-off-by: Ashley Pittman <[email protected]> Signed-off-by: Jeff Olivier <[email protected]>

daosbuild1 reviewed Jul 14, 2023

View reviewed changes

use -DER_NOTAPPLICABLE

edcab41

Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>

daosbuild1 reviewed Jul 14, 2023

View reviewed changes

ashleypittman added 2 commits July 17, 2023 11:28

Merge branch 'master' into amd/dfuse-evict-cleanup

66a9cd4

Switch back to DER_MISC

ebb2668

Test-tag: dfuse Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>

ashleypittman force-pushed the amd/dfuse-evict-cleanup branch from ceab235 to ebb2668 Compare July 17, 2023 11:34

daosbuild1 reviewed Jul 17, 2023

View reviewed changes

ashleypittman commented Jul 17, 2023

View reviewed changes

ashleypittman marked this pull request as ready for review July 17, 2023 11:37

ashleypittman requested review from a team as code owners July 17, 2023 11:37

ashleypittman requested review from mjmac and removed request for a team July 17, 2023 11:37

daltonbohning approved these changes Jul 17, 2023

View reviewed changes

ashleypittman requested review from wiliamhuang and mchaarawi July 20, 2023 12:57

wiliamhuang approved these changes Jul 20, 2023

View reviewed changes

ashleypittman requested a review from a team July 20, 2023 15:58

mchaarawi removed the request for review from a team July 21, 2023 16:41

Merge branch 'master' into amd/dfuse-evict-cleanup

8160a64

Features: dfuse

daosbuild1 reviewed Jul 21, 2023

View reviewed changes

ashleypittman merged commit a20b521 into master Jul 23, 2023

ashleypittman deleted the amd/dfuse-evict-cleanup branch July 23, 2023 19:27

jolivier23 mentioned this pull request Apr 26, 2024

DAOS-14411 dfuse: Add daos fs query #14261

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-12751 dfuse: Improve evict command. #12633

DAOS-12751 dfuse: Improve evict command. #12633

ashleypittman commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Jul 17, 2023

daosbuild1 left a comment

ashleypittman Jul 17, 2023

daltonbohning Jul 17, 2023

ashleypittman Jul 17, 2023

daltonbohning Jul 17, 2023

ashleypittman Jul 17, 2023

ashleypittman Jul 17, 2023

ashleypittman Jul 18, 2023

mchaarawi commented Jul 21, 2023

ashleypittman commented Jul 21, 2023

mchaarawi commented Jul 21, 2023

ashleypittman commented Jul 21, 2023

mchaarawi commented Jul 21, 2023

daosbuild1 left a comment

DAOS-12751 dfuse: Improve evict command. #12633

DAOS-12751 dfuse: Improve evict command. #12633

Conversation

ashleypittman commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jul 17, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

ashleypittman Jul 17, 2023

Choose a reason for hiding this comment

daltonbohning Jul 17, 2023

Choose a reason for hiding this comment

ashleypittman Jul 17, 2023

Choose a reason for hiding this comment

daltonbohning Jul 17, 2023

Choose a reason for hiding this comment

ashleypittman Jul 17, 2023

Choose a reason for hiding this comment

ashleypittman Jul 17, 2023

Choose a reason for hiding this comment

ashleypittman Jul 18, 2023

Choose a reason for hiding this comment

mchaarawi commented Jul 21, 2023

ashleypittman commented Jul 21, 2023

mchaarawi commented Jul 21, 2023

ashleypittman commented Jul 21, 2023

mchaarawi commented Jul 21, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment