Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14639 dfuse: Do not allow security. xattr to be set. #13333

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

ashleypittman
Copy link
Contributor

fuse will call this often to read non-existent xattrs for every write request
so short-circuit these to avoid server round-trips.

Required-githooks: true
Test-tag: dfuse

Signed-off-by: Ashley Pittman [email protected]

fuse will call this often to read non-existent xattrs for every write request
so short-circuit these to avoid server round-trips.

Required-githooks: true
Test-tag: dfuse

Signed-off-by: Ashley Pittman <[email protected]>
Copy link

github-actions bot commented Nov 13, 2023

Bug-tracker data:
Ticket title is 'kernel calling getxattr security.capability on every write.'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-14639

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman ashleypittman marked this pull request as ready for review November 13, 2023 17:53
@ashleypittman ashleypittman requested review from a team as code owners November 13, 2023 17:53
Features: dfuse

Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13333/3/display/redirect

Comment on lines +219 to +221
'scons -C {} --jobs {}'.format(build_dir, intercept_jobs),
'scons -C {} --jobs {} install'.format(build_dir, intercept_jobs),
'daos filesystem query {}'.format(mount_dir)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was previously only building but not installing? And does installing now somehow cover these tests changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was previously building but not installing.

The real change in this file is calling daos filesystem query at the end of the job to see the statistics, having that data tells us what dfuse is doing which is how I found this issue. Not doing an install was an oversight but should just be a bunch of renames so I don't expect problems with it.

Features: dfuse

Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13333/4/execution/node/1130/log

daltonbohning
daltonbohning previously approved these changes Nov 16, 2023
Features: dfuse

Required-githooks: true
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13333/5/execution/node/1466/log

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13333/7/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13333/8/testReport/

@ashleypittman ashleypittman merged commit bf06d1f into master Nov 21, 2023
@ashleypittman ashleypittman deleted the amd/dfuse-sec-xattr branch November 21, 2023 20:44
yyyshi pushed a commit to yyyshi/daos that referenced this pull request Nov 22, 2023
…#13333)

fuse will call this often to read non-existent xattrs for every write request
so short-circuit these to avoid server round-trips.

Signed-off-by: Ashley Pittman <[email protected]>
Signed-off-by: shiying <[email protected]>
jolivier23 pushed a commit that referenced this pull request Feb 28, 2024
fuse will call this often to read non-existent xattrs for every write request
so short-circuit these to avoid server round-trips.

Required-githooks: true

Change-Id: I3337b1724f237cc50a5a537e0844f05f0ed9cc61
Signed-off-by: Ashley Pittman <[email protected]>
jolivier23 pushed a commit that referenced this pull request Apr 10, 2024
fuse will call this often to read non-existent xattrs for every write request
so short-circuit these to avoid server round-trips.

Required-githooks: true

Change-Id: I3337b1724f237cc50a5a537e0844f05f0ed9cc61
Signed-off-by: Ashley Pittman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants