Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14353 objects: check permission before retry #13451

Merged
merged 1 commit into from
Dec 13, 2023
Merged

DAOS-14353 objects: check permission before retry #13451

merged 1 commit into from
Dec 13, 2023

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Dec 6, 2023

Check RF and other performance before retry check, so non-allowed write should return failuer immediately, instead of retrying endless.

Use rebuild/reintegrate_pool_rank in daos_container test to avoid DER_BUSY failure.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1
DAOS-14353 objects: check permission before retry
eaa5d9a 
Check RF and other performance before retry check, so
non-allowed write should return failuer immediately,
instead of retrying endless.

Use rebuild/reintegrate_pool_rank in daos_container test
to avoid DER_BUSY failure.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Bug-tracker data:
Ticket title is 'FTEST_daos_test.DAOS_Container.CONT24 - "DER_BUSY" != "DER_SUCCESS"'
Status is 'Open'
Labels: 'ci_impact,pr_test,release/2.4,triaged'
Errors are Unknown component
https://daosio.atlassian.net/browse/DAOS-14353

@wangdi1 wangdi1 requested a review from Nasf-Fan December 6, 2023 21:08
daosbuild1
daosbuild1 reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@wangdi1
Copy link
Contributor Author

wangdi1 commented Dec 12, 2023

It actually passed all CI tests. ping

@wangdi1 wangdi1 requested a review from a team December 13, 2023 17:58
@wangdi1
Copy link
Contributor Author

wangdi1 commented Dec 13, 2023

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13451/1/pipeline-graph/. actually passed all CI tests.

@mchaarawi mchaarawi merged commit 0884b82 into master Dec 13, 2023
@mchaarawi mchaarawi deleted the wangdi/daos_14353 branch December 13, 2023 23:21
wangdi1 added a commit that referenced this pull request Jan 8, 2024
@wangdi1
DAOS-14353 object: check permission before retry (#13451)
3ad2945 
Check RF and other performance before retry check, so
non-allowed write should return failuer immediately,
instead of retrying endless.

Use rebuild/reintegrate_pool_rank in daos_container test
to avoid DER_BUSY failure.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Feb 28, 2024
@wangdi1 @jolivier23
DAOS-14353 object: check permission before retry (#13451)
6817b82 
Check RF and other performance before retry check, so
non-allowed write should return failuer immediately,
instead of retrying endless.

Use rebuild/reintegrate_pool_rank in daos_container test
to avoid DER_BUSY failure.

Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Mar 12, 2024
@wangdi1 @jolivier23
DAOS-14353 object: check permission before retry (#13451)
6ecfa5f 
Check RF and other performance before retry check, so
non-allowed write should return failuer immediately,
instead of retrying endless.

Use rebuild/reintegrate_pool_rank in daos_container test
to avoid DER_BUSY failure.

Change-Id: I421defce185a928ebd3e52f59f1b19247d90f420
Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Apr 10, 2024
@wangdi1 @jolivier23
DAOS-14353 object: check permission before retry (#13451)
18d939f 
Check RF and other performance before retry check, so
non-allowed write should return failuer immediately,
instead of retrying endless.

Use rebuild/reintegrate_pool_rank in daos_container test
to avoid DER_BUSY failure.

Change-Id: I421defce185a928ebd3e52f59f1b19247d90f420
Signed-off-by: Di Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangdi1 @liuxuezhao @Nasf-Fan @daosbuild1 @mchaarawi