Solc 0.6.0 #316
Merged
Solc 0.6.0 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The main hurdle to allowing for solc-0.6 has been the breaking change in the srcmap format, which this PR supports. Together with dapphub/ds-test#14, the basic I suggest we don't let updating the rest of ds-* block this though |
MrChico
commented
Mar 19, 2020
| done (xs, s, p) = let (xs', _, _) = go ';' (xs, s, p) in xs' | ||
|
|
||
| go ':' (xs, F1 [] _, p@(SM a _ _ _)) = (xs, F2 a [] 1, p) | ||
| go ':' (xs, F1 ds k, p) = (xs, F2 (k * digits ds) [] 1, p) | ||
| go :: Char -> (Seq SrcMap, SrcMapParseState, SrcMap) -> (Seq SrcMap, SrcMapParseState, SrcMap) |
There was a problem hiding this comment.
Good luck reviewing this!
asymmetric
reviewed
Mar 24, 2020
|
I'm fine with merging this if you've tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft pr for visibility,
Non-exhaustive list of things that need fixing in order to support
0.6.0are:Solidity.hsto accomodate the new srcmap format