Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few fixes for wait_for_instantlock #3123

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Few fixes for wait_for_instantlock #3123

merged 2 commits into from
Oct 1, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Sep 29, 2019 •
edited
Loading

Pls see individual commits for details.

Note: p2p-instantsend.py is expected to fail randomly now because of propagation issues which were not caught previously (should be fixed via #3124).

Note2: Also needs #3122 to be merged first to import wait_until, will rebase included similar changes here

@UdjinM6 UdjinM6 added this to the 14.1 milestone Sep 29, 2019
codablock
codablock previously approved these changes Sep 29, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock
Copy link

codablock commented Oct 1, 2019 •
edited
Loading

Needs rebase. EDIT: #3124 is merged as well now.

UdjinM6 added 2 commits October 1, 2019 11:31
@UdjinM6
Fix wait_for_instantlock to make it fail if instantlock wasn't aqui…
ebb9859 
…red, use `wait_until`

Currently it simply returns False if islock failed but that's not the way we use it (we never check results).
@UdjinM6
Wait for txes to propagate before checking for instantlock
4d21e97
codablock
codablock approved these changes Oct 1, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Oct 1, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 82ebba1 into dashpay:develop Oct 1, 2019
@UdjinM6 UdjinM6 mentioned this pull request Oct 1, 2019
Merged
PastaPastaPasta
PastaPastaPasta reviewed Oct 1, 2019
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-utACK

barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@UdjinM6
Few fixes for wait_for_instantlock (dashpay#3123)
2745d04 
* Fix `wait_for_instantlock` to make it fail if instantlock wasn't aquired, use `wait_until`

Currently it simply returns False if islock failed but that's not the way we use it (we never check results).

* Wait for txes to propagate before checking for instantlock
@UdjinM6 UdjinM6 deleted the fixwaitis branch November 26, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments

@nmarley nmarley nmarley approved these changes

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
4 participants
@UdjinM6 @codablock @nmarley @PastaPastaPasta