Also consider txindex for transactions in AlreadyHave() #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
Sep 30, 2019
This avoids many false negatives where TXs are announced to us which are already mined and then were spent later.
codablock
force-pushed
the
pr_alreadyhave_optimizations
branch
from
d0eb676 to
82b81d8
Compare
PastaPastaPasta
requested changes
Sep 30, 2019
| @@ -240,6 +240,10 @@ bool CBlockTreeDB::WriteBatchSync(const std::vector<std::pair<int, const CBlockF | |||
| return WriteBatch(batch, true); | |||
| } | |||
|
|
|||
| bool CBlockTreeDB::HasTxIndex(const uint256& txid) { | |||
There was a problem hiding this comment.
I understand that you are trying to replicate surrounding code, but when adding new code we should follow code guidelines (ie move the { down to the next line)
| @@ -121,6 +121,7 @@ class CBlockTreeDB : public CDBWrapper | |||
| bool ReadLastBlockFile(int &nFile); | |||
| bool WriteReindexing(bool fReindex); | |||
| bool ReadReindexing(bool &fReindex); | |||
| bool HasTxIndex(const uint256 &txid); | |||
There was a problem hiding this comment.
Again, I understand you are replicating surrounding code, but according to clang, it should be:
Suggested change
| bool HasTxIndex(const uint256 &txid); | |
| bool HasTxIndex(const uint256& txid); |
|
After some discussion on Slack I'm leaning towards merging it as is in this specific case. |
codablock
added a commit
to codablock/dash
that referenced
this pull request
Nov 18, 2019
This avoids many false negatives where TXs are announced to us which are already mined and then were spent later.
codablock
added a commit
to codablock/dash
that referenced
this pull request
Nov 19, 2019
This avoids many false negatives where TXs are announced to us which are already mined and then were spent later.
MIPPL
pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 24, 2019
* commit '8b14adb206d76fbc6307385999a1c512052e93fa': (21 commits) [v0.14.0.x] Update release notes with change log (dashpay#3213) [v0.14.0.x] Bump version to 0.14.0.4 and draft release notes (dashpay#3203) Circumvent BIP69 sorting in fundrawtransaction.py test (dashpay#3100) Fix compile issues Merge bitcoin#11397: net: Improve and document SOCKS code Slightly optimize ApproximateBestSubset and its usage for PS txes (dashpay#3184) Update activemn if protx info changed (dashpay#3176) Actually update spent index on DisconnectBlock (dashpay#3167) Only track last seen time instead of first and last seen time (dashpay#3165) Merge bitcoin#17118: build: depends macOS: point --sysroot to SDK (dashpay#3161) Simulate BlockConnected/BlockDisconnected for PS caches Few fixes related to SelectCoinsGroupedByAddresses (dashpay#3144) Various fixes for mixing queues (dashpay#3138) Also consider txindex for transactions in AlreadyHave() (dashpay#3126) Ignore recent rejects filter for locked txes (dashpay#3124) Make orphan TX map limiting dependent on total TX size instead of TX count (dashpay#3121) Update/modernize macOS plist (dashpay#3074) Fix bip69 vs change position issue (dashpay#3063) Partially revert 3061 (dashpay#3150) Fix SelectCoinsMinConf to allow instant respends (dashpay#3061) ... # Conflicts: # configure.ac # doc/man/biblepay-cli.1 # doc/man/biblepay-qt.1 # doc/man/biblepay-tx.1 # doc/man/biblepayd.1 # doc/release-notes.md # src/clientversion.h # src/wallet/wallet.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids many false negatives where TXs are announced to us which are
already mined and then were spent later.
This also avoids TXs going into the orphan map even though they were already mined.