Fix scripted diff check condition #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
fixscripteddiff
branch
4 times, most recently
from
901ce06 to
9138857
Compare
UdjinM6
force-pushed
the
fixscripteddiff
branch
from
9138857 to
0b10151
Compare
|
Took me a while to figure it out but it finally works now I think. There are 2 debug scripted-diff-s here: |
UdjinM6
changed the title
|
@PastaPastaPasta these changes are from 2 debug commits I included to show that the patch actually works as expected, I'll drop them before merging. |
|
Yup, once those are removed, I'm utACKed for merge |
|
Cool :) I'll just wait for more people to comment here before removal to make sure they had a change to review current results. |
codablock
reviewed
Oct 1, 2019
UdjinM6
force-pushed
the
fixscripteddiff
branch
from
0b10151 to
f4eecbc
Compare
|
Dropped 2 debug commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue discovered in #3122