Multiple fixes for ChainLock tests #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
force-pushed
the
pr_fix_chainlock_tests
branch
from
81f7123 to
c6fafcd
Compare
codablock
changed the title
|
Needs rebase |
…block_all_nodes wait_for_chainlocked_tip_all_nodes did wait for the tip of each individual node, which would not necessarily be the same. We should only allow to explicitly specify which block to wait for.
Same as with wait_for_chainlocked_tip_all_nodes
codablock
force-pushed
the
pr_fix_chainlock_tests
branch
from
c8d0a66 to
28997d4
Compare
|
Rebased on develop |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
* Add timeout params to wait_for*_chainlock methods * Give chainlocks more time in specific case * Add logs to llmq-chainlock.py * Replace wait_for_chainlocked_tip_all_nodes with wait_for_chainlocked_block_all_nodes wait_for_chainlocked_tip_all_nodes did wait for the tip of each individual node, which would not necessarily be the same. We should only allow to explicitly specify which block to wait for. * Get rid of wait_for_chainlocked_tip Same as with wait_for_chainlocked_tip_all_nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to increase the timeout when waiting for a chainlock after generating 20 blocks. Test failures seen on Travis were very close to getting the chainlock but then failed due to timeouts. This PR also adds some logging to the tests so that it's easier to debug this in the future.
Also get rid of
wait_for_chainlocked_tipandwait_for_chainlocked_tip_all_nodesas of the discussion in #3122 (comment)This builds on #3122 and needs a rebase after that is merged.