Actually pass extra_args to nodes in assumevalid.py #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up assumevalid.py from 22s to 7s on my machine. On travis, this should be an improvement of a few minutes. Without this, Travis actually fails due to block download timeouts.
UdjinM6
approved these changes
Oct 1, 2019
|
How can I run/profile a single test? |
|
@PastaPastaPasta You should be able to do this to run a single test (i.e. |
|
utACK Dropped from 23s to 8s for me as well |
|
fyi, Travis failures are not related to this PR |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
This speeds up assumevalid.py from 22s to 7s on my machine. On travis, this should be an improvement of a few minutes. Without this, Travis actually fails due to block download timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up assumevalid.py from 22s to 7s on my machine. On travis, this
should be an improvement of a few minutes. Without this, Travis actually
fails due to block download timeouts.
extra_args was ignored since the backporting of TestNode and the failure was not happening locally but later on Travis (cron job with extended tests).