Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] RPC help updates #3134

Merged
merged 3 commits into from
Oct 3, 2019
Merged

[Trivial] RPC help updates #3134

merged 3 commits into from
Oct 3, 2019

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Oct 2, 2019 •
edited
Loading

Related to #3113 (addnode)

@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 2, 2019
UdjinM6
UdjinM6 previously approved these changes Oct 2, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley previously approved these changes Oct 2, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@thephez thephez dismissed stale reviews from nmarley and UdjinM6 via 026e637 October 2, 2019 14:50
@thephez
Copy link
Collaborator Author

thephez commented Oct 2, 2019

Added 026e637 because I constantly forget to do this and the example does not work without the single quotes

UdjinM6
UdjinM6 approved these changes Oct 3, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

codablock
codablock approved these changes Oct 3, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Oct 3, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK @ 026e637

@UdjinM6 UdjinM6 merged commit f8e238c into dashpay:develop Oct 3, 2019
@thephez thephez deleted the 0.14.1/rpc-help-updates branch October 3, 2019 14:37
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@thephez
[Trivial] RPC help updates (dashpay#3134)
bea3c7b 
* Remove SegWit reference from addnode

* Add missing merkleRootQuorums to getblock

* Wrap example JSON in single quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@codablock codablock codablock approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
4 participants
@thephez @nmarley @codablock @UdjinM6