Some refactoring for spork related functionality in tests #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, utACK after rebase |
… multikeysporks.py to better match actual functionality -BEGIN VERIFY SCRIPT- sed -i 's/_test_spork_state/_test_spork_value/g' test/functional/multikeysporks.py -END VERIFY SCRIPT-
UdjinM6
force-pushed
the
refsporksintests
branch
from
3544c0b to
eda5711
Compare
|
Rebased |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
* Use `wait_until` in sporks.py * Drop unused spork functions in `dip3-deterministicmns.py` * Use `wait_until` in multikeysporks.py * scripted-diff: Rename `*_test_spork_state` to `*_test_spork_value` in multikeysporks.py to better match actual functionality -BEGIN VERIFY SCRIPT- sed -i 's/_test_spork_state/_test_spork_value/g' test/functional/multikeysporks.py -END VERIFY SCRIPT-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on #3136 (because of
wait_to_syncinsporks.py), will rebase.