Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt: Remove old themes #3141

Merged
merged 11 commits into from
Oct 10, 2019
Merged

Qt: Remove old themes #3141

merged 11 commits into from
Oct 10, 2019

Conversation

nmarley
Copy link

@nmarley nmarley commented Oct 8, 2019

This is split out from #3000 and removes all except the "light" theme in preparation for a bit more extensive refresh. This refresh moves images and layout around and won't work with the current theme layout.

@UdjinM6
Copy link

UdjinM6 commented Oct 8, 2019 •
edited
Loading

This basically leaves us with one single theme again and what it means is that we don't have to care about themes for any kind of images at all now and thus we can "squash" things like this UdjinM6@721288e. Also, we can finally clean up some legacy drkblue mess UdjinM6@06e1f59.

And I would actually keep the Traditional theme - it requires almost no additional code and no images after the "squashing" commit, so it's very lightweight (UdjinM6@b190fd8) but it can be very useful for people running qt wallets in weird environments (some exotic linux distros, crazy small resolutions etc.). I know that at least some people were actually using this theme at some point.

@codablock
Copy link

Big fan of removing the themes mess as proposed by UdjinM6 👍

@nmarley
Copy link
Author

nmarley commented Oct 9, 2019

Agree on removing themes and cleaning up drkblue. Traditional seems to still work so don't mind either way on that one. FF'ed to 06e1f59.

@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 9, 2019
UdjinM6
UdjinM6 approved these changes Oct 9, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly tested ACK

@UdjinM6
Copy link

UdjinM6 commented Oct 9, 2019

Travis failed due to some (unrelated) apt-get timeout issues.

codablock
codablock approved these changes Oct 10, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 1cbe280 into dashpay:develop Oct 10, 2019
@nmarley nmarley deleted the qt-remove-old-themes branch October 10, 2019 14:19
@nmarley nmarley mentioned this pull request Oct 23, 2019
Merged
@UdjinM6 UdjinM6 mentioned this pull request Jan 13, 2020
Merged
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@nmarley
Qt: Remove old themes (dashpay#3141)
8672d2d 
* Remove crownium files

* Remove trad theme files

* Remove drkblue theme files

* Remove light-retro theme files

* Remove old themes from optimize-pngs script

* Remove refs to old themes in Makefile.qt

* Remove more old theme file references

* Remove old themes from options dialog

* No need to care about themes for images and icons anymore

* Bring `trad` back

* Drop remaining `drkblue` references

Rename files that are actually used and drop no longer needed ones
andrewtookay pushed a commit to Alterdot/Alterdot that referenced this pull request Jul 24, 2021
@nmarley @andrewtookay
remove old Dash themes (backport dashpay#3141)
26bc375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
3 participants
@nmarley @UdjinM6 @codablock