Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gitlab cache issues #3160

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Fix Gitlab cache issues #3160

merged 3 commits into from
Oct 17, 2019

Conversation

codablock
Copy link

@codablock codablock commented Oct 17, 2019 •
edited
Loading

See individual commits

@codablock
Make parent cache download quiet
aea1dd7 
This spammed logs quite a bit
@codablock codablock added this to the 14.1 milestone Oct 17, 2019
@codablock
Add "-p" to "mkdir $CI_PROJECT_DIR/cache-artifact"
9af7d11 
Otherwise the after_script is silently aborted when the dir already exists.
@codablock codablock changed the title Make parent cache download quiet Fix Gitlab cache issues Oct 17, 2019
@codablock
Copy link
Author

test

@codablock
Extract parent cache artifact in own directory and later delete it
3ee2f12 
Otherwise we end up having "testlogs" (and maybe other stuff) in the
project directory, which causes future failures.
UdjinM6
UdjinM6 approved these changes Oct 17, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock merged commit 4db91c6 into dashpay:develop Oct 17, 2019
@codablock codablock deleted the pr_gitlab_quiet branch October 17, 2019 09:52
PastaPastaPasta
PastaPastaPasta reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-utACK

barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@codablock
Fix Gitlab cache issues (dashpay#3160)
205ad32 
* Make parent cache download quiet

This spammed logs quite a bit

* Add "-p" to "mkdir $CI_PROJECT_DIR/cache-artifact"

Otherwise the after_script is silently aborted when the dir already exists.

* Extract parent cache artifact in own directory and later delete it

Otherwise we end up having "testlogs" (and maybe other stuff) in the
project directory, which causes future failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
3 participants
@codablock @UdjinM6 @PastaPastaPasta