Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty strings in protx update_registrar as an option to re-use current values #3177

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Allow empty strings in protx update_registrar as an option to re-use current values #3177

merged 2 commits into from
Oct 29, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Oct 28, 2019

No description provided.

@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Oct 28, 2019
@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 28, 2019
codablock
codablock reviewed Oct 29, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

@UdjinM6 @codablock
Update src/rpc/rpcevo.cpp
40f660e 
Co-Authored-By: Alexander Block <[email protected]>
codablock
codablock approved these changes Oct 29, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

thephez
thephez approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Oct 29, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 64a913d into dashpay:develop Oct 29, 2019
@UdjinM6 UdjinM6 mentioned this pull request Oct 30, 2019
Merged
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@UdjinM6 @codablock
Allow empty strings in protx update_registrar as an option to re-us…
1eb9134 
…e current values (dashpay#3177)

* Allow empty strings in `protx update_registrar` as an option to re-use current values

* Update src/rpc/rpcevo.cpp

Co-Authored-By: Alexander Block <[email protected]>
@UdjinM6 UdjinM6 deleted the registraremptystr branch November 26, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@codablock codablock codablock approved these changes

@thephez thephez thephez approved these changes

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
4 participants
@UdjinM6 @nmarley @codablock @thephez