Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nonLockedTxsByInputs #3178

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Refactor nonLockedTxsByInputs #3178

merged 1 commit into from
Oct 29, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Oct 28, 2019

IMO it feels more natural to just use COutPoint as an index here (unless I'm missing smth).

@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 28, 2019
codablock
codablock approved these changes Oct 29, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but I'm wondering why I did this in the first place. I usually do this when I need to mimic the behavior of an ordered map so that I can get all outpoints for the same txid very fast, but this is obviously not needed here.

@UdjinM6
Copy link
Author

UdjinM6 commented Oct 29, 2019

Yep, I was wondering too :) Probably just a leftover from some older ideas or smth.

nmarley
nmarley approved these changes Oct 29, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, concept ACK

@UdjinM6 UdjinM6 merged commit bbd9b10 into dashpay:develop Oct 29, 2019
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@UdjinM6
Refactor nonLockedTxsByInputs (dashpay#3178)
e5d633f
@UdjinM6 UdjinM6 deleted the refactornonlockbyinp branch November 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @nmarley @codablock