More Qt tweaks #3200
Merged
More Qt tweaks #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking at the first before and after image, why are a couple pixels missing on each corner? |
|
@PastaPastaPasta good catch, I didn't notice this! It looks like the outer border is still rounded for some reason and I can't find a way to fix this. I wonder how things look like on other OSes... but thinking more about it - why do we have the black border at all here? There is no such thing for context menus for example (which are kind of similar to comboboxes in some sense). Pushed 3cd14a5 with the updated style and added new screenshot in the PR description. |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
* Fix combobox popup style * Unify margins/paddings/height for lineedits/comboboxes/spinboxes * Drop walletframe_background * Add transparency to unchecked.png * Alternative solution for comboboxes (no border for popups, add paddings in QListView)
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
* Fix combobox popup style * Unify margins/paddings/height for lineedits/comboboxes/spinboxes * Drop walletframe_background * Add transparency to unchecked.png * Alternative solution for comboboxes (no border for popups, add paddings in QListView) Signed-off-by: cevap <[email protected]>
cryptolinux
pushed a commit
to cryptolinux/ion
that referenced
this pull request
Feb 6, 2021
* Fix combobox popup style * Unify margins/paddings/height for lineedits/comboboxes/spinboxes * Drop walletframe_background * Add transparency to unchecked.png * Alternative solution for comboboxes (no border for popups, add paddings in QListView) Signed-off-by: cevap <[email protected]>
ckti
pushed a commit
to ckti-gitian-ion/ion
that referenced
this pull request
Mar 29, 2021
* Fix combobox popup style * Unify margins/paddings/height for lineedits/comboboxes/spinboxes * Drop walletframe_background * Add transparency to unchecked.png * Alternative solution for comboboxes (no border for popups, add paddings in QListView) Signed-off-by: cevap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12439e9 + 3cd14a5 - remove the border in popups
Before:
After 12439e9:
After 12439e9 + 3cd14a5:
492e810 - unify the look of elements and fix the (ugly) outline
Before:
After:
7bd524d - the background is just a huge white png now, this can be easily done via css instead (no visual changes)
14f1a8f - changed the inner part to be a transparent one (no visual changes)