trivial: adding SVG and high contrast icons #3209
Conversation
- noticed that someone already contributed all my pixmaps I have been using for my builds (thank you, whoever you were). The favicon was left out. Adding that as well. It is useful from a completist perspective and have users a resource they can just use if they have need of a favicon for their project.
Purpose: for accessibility, if QT wallet is packaged (linux) correctly, when the user switches to high contrast in their desktop environment the high contrast icons will be used. The packaging should land these icons in the `/usr/share/icons/HighContrast` and `/usr/share/icons/hicolor` trees.
|
|
|
Well, crap. If you push this, I will fix it with another PR, if you don't mind. |
|
Hmm.. Why not fix it here? |
|
Cuz my squash-foo is minimal. :) |
|
Just add the right one on top then, we'll squash on merge anyway. |
|
Cool. Wilco. |
| @@ -0,0 +1,89 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
Should this specifically be licensed under MIT?
There was a problem hiding this comment.
@PastaPastaPasta -- Is there a request here for me? You want me to add some metadata or some such? Or just stick a license file in the same directory?
There was a problem hiding this comment.
Hmm... I'm not sure if we need this since it's kind of set globally here https://github.com/dashpay/dash#license and https://github.com/dashpay/dash/blob/master/COPYING. The only 2 svg files with an explicit licence I found are https://github.com/dashpay/dash/blob/master/contrib/macdeploy/background.svg?short_path=9c330af#L5-L9 and https://github.com/dashpay/dash/blob/master/src/qt/res/src/bitcoin.svg?short_path=14cf0c5#L4 (I wonder why we have it...) but it's also MIT there and these files are rather old. Other/newer files in https://github.com/dashpay/dash/tree/master/src/qt/res/src have no explicit info about their licence for example. Thoughts @nmarley ? (and maybe @strophy)
There was a problem hiding this comment.
I didn't think there was a need to explicitly add a license for these since they're a small part of a larger work which is already MIT licensed unless otherwise stated.
Is there some reason (or just precedent) why you raised this concern @PastaPastaPasta ?
There was a problem hiding this comment.
Not really, I just know that all of our source files specifically state MIT so I just wanted to bring up the thought
| @@ -0,0 +1,89 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
We already have quite a few svg files with no explicit licence as I pointed out here #3209 (comment) so I think we are fine to merge it as is and fix them all later if needed.
utACK
* adding favicon image - noticed that someone already contributed all my pixmaps I have been using for my builds (thank you, whoever you were). The favicon was left out. Adding that as well. It is useful from a completist perspective and have users a resource they can just use if they have need of a favicon for their project. * trivial: adding SVG and high contrast icons Purpose: for accessibility, if QT wallet is packaged (linux) correctly, when the user switches to high contrast in their desktop environment the high contrast icons will be used. The packaging should land these icons in the `/usr/share/icons/HighContrast` and `/usr/share/icons/hicolor` trees. * trivial: HighContrast SVG is actually HighContrast now.
* adding favicon image - noticed that someone already contributed all my pixmaps I have been using for my builds (thank you, whoever you were). The favicon was left out. Adding that as well. It is useful from a completist perspective and have users a resource they can just use if they have need of a favicon for their project. * trivial: adding SVG and high contrast icons Purpose: for accessibility, if QT wallet is packaged (linux) correctly, when the user switches to high contrast in their desktop environment the high contrast icons will be used. The packaging should land these icons in the `/usr/share/icons/HighContrast` and `/usr/share/icons/hicolor` trees. * trivial: HighContrast SVG is actually HighContrast now.
Includes changes in specfile to accommodate dashpay/dash#3209
* adding favicon image - noticed that someone already contributed all my pixmaps I have been using for my builds (thank you, whoever you were). The favicon was left out. Adding that as well. It is useful from a completist perspective and have users a resource they can just use if they have need of a favicon for their project. * trivial: adding SVG and high contrast icons Purpose: for accessibility, if QT wallet is packaged (linux) correctly, when the user switches to high contrast in their desktop environment the high contrast icons will be used. The packaging should land these icons in the `/usr/share/icons/HighContrast` and `/usr/share/icons/hicolor` trees. * trivial: HighContrast SVG is actually HighContrast now. Signed-off-by: cevap <[email protected]>
* adding favicon image - noticed that someone already contributed all my pixmaps I have been using for my builds (thank you, whoever you were). The favicon was left out. Adding that as well. It is useful from a completist perspective and have users a resource they can just use if they have need of a favicon for their project. * trivial: adding SVG and high contrast icons Purpose: for accessibility, if QT wallet is packaged (linux) correctly, when the user switches to high contrast in their desktop environment the high contrast icons will be used. The packaging should land these icons in the `/usr/share/icons/HighContrast` and `/usr/share/icons/hicolor` trees. * trivial: HighContrast SVG is actually HighContrast now. Signed-off-by: cevap <[email protected]>
* adding favicon image - noticed that someone already contributed all my pixmaps I have been using for my builds (thank you, whoever you were). The favicon was left out. Adding that as well. It is useful from a completist perspective and have users a resource they can just use if they have need of a favicon for their project. * trivial: adding SVG and high contrast icons Purpose: for accessibility, if QT wallet is packaged (linux) correctly, when the user switches to high contrast in their desktop environment the high contrast icons will be used. The packaging should land these icons in the `/usr/share/icons/HighContrast` and `/usr/share/icons/hicolor` trees. * trivial: HighContrast SVG is actually HighContrast now. Signed-off-by: cevap <[email protected]>
Purpose: for accessibility, if QT wallet is packaged (linux) correctly,
when the user switches to high contrast in their desktop environment
the high contrast icons will be used.
The packaging should land these icons in the
/usr/share/icons/HighContrastand/usr/share/icons/hicolortrees.Note: The dashNN.png files already present in the pixmaps directory are hicolor icons.