Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark theme #3216

Merged
merged 8 commits into from
Nov 22, 2019
Merged

Add Dark theme #3216

merged 8 commits into from
Nov 22, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Nov 21, 2019

Main screens:
Screenshot 2019-11-22 at 00 24 27
Screenshot 2019-11-22 at 00 24 47
Screenshot 2019-11-22 at 00 36 36
Screenshot 2019-11-22 at 00 36 52
Screenshot 2019-11-22 at 00 44 23
Screenshot 2019-11-22 at 00 39 02

Debug window:
69379562-bf8afd80-0cc1-11ea-87bd-03805c5fc57f
Screenshot 2019-11-22 at 00 40 58
Screenshot 2019-11-22 at 01 00 43
Screenshot 2019-11-22 at 00 41 53
Screenshot 2019-11-22 at 01 00 51

Options:
Screenshot 2019-11-22 at 00 39 28
Screenshot 2019-11-22 at 00 39 52
etc.

Few more examples:
Screenshot 2019-11-22 at 00 45 20
Screenshot 2019-11-22 at 00 39 17
Screenshot 2019-11-22 at 00 44 43
Screenshot 2019-11-22 at 00 24 05

I think I have everything covered finally and no ugly parts should remain, pls test :)

@UdjinM6 UdjinM6 added this to the 15 milestone Nov 21, 2019
codablock
codablock previously approved these changes Nov 22, 2019
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley previously approved these changes Nov 22, 2019
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok on my display. Would prefer to drop hires if we will be merging #3217 .

slightly tested ACK

Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK @ 9820ca9

@UdjinM6 UdjinM6 merged commit bb7a32d into dashpay:develop Nov 22, 2019
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
* Copy light(-hires).css -> dark(-hires).css (with no changes yet)

* Add dark(-hires).css to makefile/qrc and show them in theme selector

* Dark theme (css part)

* Do not style unit selector in status bar via platform styles, use css instead

* No coloring via forms (*.ui)

* Implement and use helpers to style parts of rich text differently for light and dark themes

* Remove dark-hires due to dashpay#3217

* Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217
FornaxA pushed a commit to ioncoincore/ion that referenced this pull request Jul 6, 2020
* Copy light(-hires).css -> dark(-hires).css (with no changes yet)

* Add dark(-hires).css to makefile/qrc and show them in theme selector

* Dark theme (css part)

* Do not style unit selector in status bar via platform styles, use css instead

* No coloring via forms (*.ui)

* Implement and use helpers to style parts of rich text differently for light and dark themes

* Remove dark-hires due to dashpay#3217

* Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217

Signed-off-by: cevap <[email protected]>
@UdjinM6 UdjinM6 deleted the darktheme branch November 26, 2020 13:25
cryptolinux pushed a commit to cryptolinux/ion that referenced this pull request Feb 6, 2021
* Copy light(-hires).css -> dark(-hires).css (with no changes yet)

* Add dark(-hires).css to makefile/qrc and show them in theme selector

* Dark theme (css part)

* Do not style unit selector in status bar via platform styles, use css instead

* No coloring via forms (*.ui)

* Implement and use helpers to style parts of rich text differently for light and dark themes

* Remove dark-hires due to dashpay#3217

* Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217

Signed-off-by: cevap <[email protected]>
ckti pushed a commit to ckti-gitian-ion/ion that referenced this pull request Mar 29, 2021
* Copy light(-hires).css -> dark(-hires).css (with no changes yet)

* Add dark(-hires).css to makefile/qrc and show them in theme selector

* Dark theme (css part)

* Do not style unit selector in status bar via platform styles, use css instead

* No coloring via forms (*.ui)

* Implement and use helpers to style parts of rich text differently for light and dark themes

* Remove dark-hires due to dashpay#3217

* Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217

Signed-off-by: cevap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants