-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dark theme #3216
Add Dark theme #3216
Conversation
… light and dark themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok on my display. Would prefer to drop hires if we will be merging #3217 .
slightly tested ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK @ 9820ca9
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217 Signed-off-by: cevap <[email protected]>
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217 Signed-off-by: cevap <[email protected]>
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217 Signed-off-by: cevap <[email protected]>
Main screens:






Debug window:





Options:


etc.
Few more examples:




I think I have everything covered finally and no ugly parts should remain, pls test :)