Tweak "Send" popup and refactor related code a bit #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
approved these changes
Nov 25, 2019
| // Limit number of displayed entries | ||
| int messageEntries = formatted.size(); | ||
| int displayedEntries = 0; | ||
| for(int i = 0; i < formatted.size(); i++){ |
There was a problem hiding this comment.
This is a very strange way of limiting a list :P
Alternative:
int messageEntries = (int)formatted.size();
while (formatted.size() > MAX_SEND_POPUP_ENTRIES) {
formatted.removeLast();
}
int displayedEntries = (int)formatted.size();
There was a problem hiding this comment.
Ahh now I see that this is just moved code. I'm fine with keeping the old code as this is not introduced in this PR.
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
Few key points: - highlight when not all recipients are displayed, move this info closer to the actual list - clarify fee rounding text for PrivateSend, wasn't accurate - show transactions size and actual fee rate explicitly - show number of inputs PrivateSend tx is going to consume and warn if this number is 10 or higher
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
Few key points: - highlight when not all recipients are displayed, move this info closer to the actual list - clarify fee rounding text for PrivateSend, wasn't accurate - show transactions size and actual fee rate explicitly - show number of inputs PrivateSend tx is going to consume and warn if this number is 10 or higher Signed-off-by: cevap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few key points:
MAX_SEND_POPUP_ENTRIES = 1temporary to take screenshots and make it easier to show the issue, not included in this PR ofc)Also refactored some related code by moving few pieces closer to the places they are actually used and/or simplifying them.
Before:
After:
