Try to avoid being marked as a bad quorum member when we sleep for too long in SleepBeforePhase #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
wakeupfaster
branch
from
a737c5f to
c81c224
Compare
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jan 10, 2020
…o long in SleepBeforePhase (dashpay#3245) * Do not sleep at the last block of the phase, it's not safe * Refactor it a bit to make it clearer what's going on here * Stop sleeping if blocks came faster than we expected
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
…o long in SleepBeforePhase (dashpay#3245) * Do not sleep at the last block of the phase, it's not safe * Refactor it a bit to make it clearer what's going on here * Stop sleeping if blocks came faster than we expected
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…o long in SleepBeforePhase (dashpay#3245) * Do not sleep at the last block of the phase, it's not safe * Refactor it a bit to make it clearer what's going on here * Stop sleeping if blocks came faster than we expected Signed-off-by: cevap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue should not happen a lot naturally and withholding blocks to cause potential issues intentionally is risky and costly due to ChainLocks. Plus
randomSleepFactorshould mostly mitigate the issue already too. However these few additional tweaks could help to bring the probability of such an event even lower I think.Pls see individual commits.
Thanks to @MrDefacto for pointing out a potential issue.