Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix params.size() check in "protx list wallet" RPC #3259

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Fix params.size() check in "protx list wallet" RPC #3259

merged 1 commit into from
Jan 1, 2020

Conversation

codablock
Copy link

This should have been "> 4" as otherwise it bails out when the height is
specified.

@codablock
Fix params.size() check in "protx list wallet" RPC
030b1c2 
This should have been "> 4" as otherwise it bails out when the height is
specified.
@codablock codablock added RPC Some notable changes to RPC params/behaviour/descriptions backport-candidate-15.x labels Dec 31, 2019
@codablock codablock added this to the 15 milestone Dec 31, 2019
@codablock codablock mentioned this pull request Dec 31, 2019
Merged
UdjinM6
UdjinM6 approved these changes Jan 1, 2020
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Jan 1, 2020
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
Copy link

UdjinM6 commented Jan 1, 2020

Guess it's better to merge this before #3106 rebase.

@UdjinM6 UdjinM6 merged commit 5ce1ee9 into dashpay:develop Jan 1, 2020
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jan 10, 2020
@codablock @UdjinM6
Fix params.size() check in "protx list wallet" RPC (dashpay#3259)
6e50a7b 
This should have been "> 4" as otherwise it bails out when the height is
specified.
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@codablock
Fix params.size() check in "protx list wallet" RPC (dashpay#3259)
f1a21a3 
This should have been "> 4" as otherwise it bails out when the height is
specified.
FornaxA pushed a commit to ioncoincore/ion that referenced this pull request Jul 6, 2020
@codablock
Fix params.size() check in "protx list wallet" RPC (dashpay#3259)
924d829 
This should have been "> 4" as otherwise it bails out when the height is
specified.

Signed-off-by: cevap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
15
Development

Successfully merging this pull request may close these issues.
3 participants
@codablock @UdjinM6 @nmarley