Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parsing corrupted log files #1817

Merged
merged 2 commits into from
May 31, 2024
Merged

Handle parsing corrupted log files #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b6285
Test corrupted log line
JCZuurmond May 31, 2024
b22e3b3
Return when corrupted log line
JCZuurmond May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/databricks/labs/ucx/installer/logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ def parse_logs(log: TextIO) -> Iterator[PartialLogRecord]:

line = log.readline()
match = pattern.match(line)
if match is None:
logger.warning(f"Logs do not match expected format ({log_format}): {line}")
return
while len(line) > 0:
assert match is not None
time, *groups, message = match.groups()
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/installer/test_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import datetime as dt
import io
import logging
from collections.abc import Iterator
from pathlib import Path
Expand Down Expand Up @@ -153,3 +154,13 @@ def test_task_logger(tmp_path):
assert "log file is" in contents["logs/assessment/run-234-0/crawl-tables.log"]
assert "something from sdk" in contents["logs/assessment/run-234-0/crawl-tables.log"]
assert "[run #234](/#job/123/run/234)" in contents["logs/assessment/run-234-0/README.md"]


def test_parse_logs_warns_for_corrupted_log_file(caplog):
corrupted_log_line = "13:56:47 INF"
with caplog.at_level(logging.WARNING, logger="databricks.labs.ucx.installer.logs"):
list(logs.parse_logs(io.StringIO(corrupted_log_line)))

last_message = caplog.messages[-1]
assert "Logs do not match expected format" in last_message
assert last_message.endswith(corrupted_log_line)