-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataset_cli): add dry-run support #12814
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
63f6049
to
448a53e
Compare
448a53e
to
3b59751
Compare
3b59751
to
6e9aade
Compare
6e9aade
to
32bd577
Compare
32bd577
to
c03ee18
Compare
if not dry_run: | ||
existing_dataset.to_yaml(Path(file)) | ||
else: | ||
click.secho(f"{dry_run_prefix}Will update file {file}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required, but it'd be super cool if we could show a diff here of what would change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do it in another PR. I think its simple enough with whats already there--- copy this file to a temp location, sync updates that temp file, and then show the diff of current vs sync.
c4dd9a0
to
a1fe1a1
Compare
a1fe1a1
to
15a69c1
Compare
Checklist