Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset_cli): add dry-run support #12814

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chakru-r
Copy link
Collaborator

@chakru-r chakru-r commented Mar 7, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 7, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-ingestion/src/datahub/cli/specific/dataset_cli.py 78.57% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chakru-r chakru-r force-pushed the dataset-cli-validation branch from 63f6049 to 448a53e Compare March 7, 2025 12:13
@chakru-r chakru-r force-pushed the dataset-cli-validation branch from 448a53e to 3b59751 Compare March 7, 2025 12:16
@chakru-r chakru-r force-pushed the dataset-cli-validation branch from 3b59751 to 6e9aade Compare March 7, 2025 12:27
@github-actions github-actions bot requested a deployment to datahub-wheels (Preview) March 7, 2025 12:28 Abandoned
@chakru-r chakru-r force-pushed the dataset-cli-validation branch from 6e9aade to 32bd577 Compare March 7, 2025 12:28
@chakru-r chakru-r force-pushed the dataset-cli-validation branch from 32bd577 to c03ee18 Compare March 7, 2025 13:43
if not dry_run:
existing_dataset.to_yaml(Path(file))
else:
click.secho(f"{dry_run_prefix}Will update file {file}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required, but it'd be super cool if we could show a diff here of what would change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it in another PR. I think its simple enough with whats already there--- copy this file to a temp location, sync updates that temp file, and then show the diff of current vs sync.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Mar 10, 2025
@chakru-r chakru-r force-pushed the dataset-cli-validation branch from c4dd9a0 to a1fe1a1 Compare March 10, 2025 18:29
@chakru-r chakru-r force-pushed the dataset-cli-validation branch from a1fe1a1 to 15a69c1 Compare March 10, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants