Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] gradle cache read expt #12830

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

chakru-r
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

HAving these as two separate tasks caused copy to always be out-of-date when
rename is run, and rename to be out-of-date when rename is done. Gradle
does not like inplace updates of any files. By combining it, the copy+rename
now appear to produce a new artificat that will be up-to-date if no sources
have changed. This caused lot of downstream jars to get rebuilt since this jar
is always out-of-dat and rebuilt everytime.
@chakru-r chakru-r force-pushed the read-cache-workflow branch from 54fb155 to 8a202ee Compare March 10, 2025 11:44
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant