Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/hive): identify partition columns in hive tables #12833

Merged
merged 8 commits into from
Mar 13, 2025
Merged

feat(ingest/hive): identify partition columns in hive tables #12833

merged 8 commits into from
Mar 13, 2025

Conversation

deepgarg-visa
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 10, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 10, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hsheth2
hsheth2 requested changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Mar 10, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Mar 11, 2025
@deepgarg-visa
Copy link
Contributor Author

/build

@deepgarg-visa deepgarg-visa requested a review from hsheth2 March 11, 2025 14:46
@deepgarg-visa
Copy link
Contributor Author

deepgarg-visa commented Mar 11, 2025 •
edited
Loading

@hsheth2 , breaking testcases have been fixed.

Following breaking step seems not to be related with this change

https://github.com/datahub-project/datahub/actions/runs/13801960849/job/38605865699?pr=12833

@deepgarg-visa
Copy link
Contributor Author

@hsheth2 please review the PR

@hsheth2 hsheth2 changed the title feat(ingestion): identify partition columns in hive table feat(ingest/hive): identify partition columns in hive tables Mar 13, 2025
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Mar 13, 2025
@hsheth2 hsheth2 merged commit eb17f80 into datahub-project:master Mar 13, 2025
104 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepgarg-visa @hsheth2