-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/mlflow): add dataset lineage #12837
Open
yoonhyejin
wants to merge
11
commits into
datahub-project:master
Choose a base branch
from
yoonhyejin:feat/mlflow-dataset-lineage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−6
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
aecdee7
[wip] add dataset lineage for mlflow
yoonhyejin f301e60
[wip] updates
yoonhyejin 4852955
update siblings
yoonhyejin b3cf810
revert back some of the changes
yoonhyejin c8e5a85
revert back some of the changes
yoonhyejin b47e008
revert back some of the changes
yoonhyejin b9fca52
Merge branch 'master' into feat/mlflow-dataset-lineage
yoonhyejin 99f77d1
remove siblings& update golden riles
yoonhyejin efad2f7
revert outputs
yoonhyejin 26cdef0
add comments
yoonhyejin cbe9f07
fix duplicated calls
yoonhyejin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo we should not be generating dataset entities for non mlflow platforms
here we should just do
hosted_dataset_urn = DatasetUrn...
. if that urn exists, lineage will show up by default. if it doesn't exist, they'll need to go into the UI and click "show hidden edges" to make them show up